This repository was archived by the owner on Mar 27, 2025. It is now read-only.
[CM-136] Improvements added dep, linter, drone #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 22, 2018 17:30
…he project otherwise the import won't work
mattiabertorello
force-pushed
the
feature/CM-136-improvements
branch
from
025a14d to
736aaf3
Compare
mattiabertorello
force-pushed
the
feature/CM-136-improvements
branch
from
4545ac3 to
21f7e8d
Compare
extra/main.go
Outdated
| @@ -34,7 +34,7 @@ type DylibMap struct { | |||
| } | |||
|
|
|||
| func main() { | |||
| var v []DylibMap | |||
| var v = make([]DylibMap, len(os.Args[1:])) | |||
There was a problem hiding this comment.
this must be like make([]DylibMap, 0, len(os.Args[1:])) to obtain the same behavior
install.go
Outdated
| interfaces, err := net.Interfaces() | ||
| var macAddresses = make([]string, len(interfaces)) |
There was a problem hiding this comment.
this must be like make([]string, 0, len(interfaces)) to obtain the same behavior
…vior For example, make([]int, 0, 10) allocates an underlying array // of size 10 and returns a slice of length 0 and capacity 10 that is // backed by this underlying array.
|
Mattia Bertorello seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the vendor folder with all the dependencies and the files Gopkg.
Run go fmt
Added the pipeline of drone with the follow checks:
After I correct some problem reported by the linter